Gatsby Migration #938
Gatsby Migration #938
Conversation
|
Thanks for moving the migration to another PR, I believe it'll be much more clear to review and also save the discussions we're having now 🙌🏼 Overall, I think you preserved the look and feel of the site well. A couple of questions to start:
|
|
They were removed by mistake. I brought them back. Could you give more details like what do you expect to see in README? |
|
@ardatan Can you please remove the deletion of these files from your original commit instead of adding them back as separate commit? |
|
@ardatan Also please review your PR and check that you migrated all files that are relevant because from a quick look I think some content is missing. |
|
@IvanGoncharov You can choose |
ardatan
force-pushed
the
new-gatsby-migration
branch
from
751ceba to
1119742
Compare
|
@IvanGoncharov I did another rebase to squash 2 commits into one, so there is only 1 commit for all changes like you asked for. Let me know if it's good for you. |
@ardatan original site has blog https://graphql.org/blog/ but this doesn’t. This is just one of the things I spotted. Will add my review soon |
Minimum would be instructions for how to run locally and see/make changes (keeping in mind that many contributors will be new to Gatsby). Our README right now is... not great so we can definitely expand on it later, but the build steps are Gatsby-specific so they should be included in this PR. |
|
@Ekwuno check this out! |
|
@saihaj @carolstran Blog section is now available and I also updated the README file. |
|
Wow, that blog is really well hidden - there's like no user-facing links anywhere to it :D I've looked at entirely as a user (not read code) I gave each page on the site a look through, and they all seem to be solid 👍🏻 I only caught one bug in the search bar not taking into account that the white version of the bar (e.g. any page other than the index) will grow to be too big for the space:
Other than that, this PR removes the travis.yml but doesn't replace it - which I assume is going to be another PR? |
|
When I click on a link on sidebar and that element is on the current page it doesn't scroll down to that element.
|
|
I have to refresh the users page for the CNCF script to work properly.
|
|
Sidebar don't match for
|
|
@saihaj Thank you :) I think they've been solved. Let me know if they persist. |
|
With what I recall discussing with @IvanGoncharov there should @ardatan I suggest that we add some sort of linter to this project. I tired running this locally and there are many Since the |
|
@saihaj I think the issues you wrote above are gone, right? In addition, I added |
|
I think it should be added in here then we can get all related fixes (if needed) in this PR. |
Hi everyone.
We @the-guild-org have decided to take on the work of the Gatsby migration in order to unblock all the contributions for graphql.org.
We tried to start with the amazing work that has been done in #913 by @saihaj but decided it was actually faster for us to start from scratch and finish all the things that need to be done in order to get this work merged.
We hope it will be ok with you to move the work here until we get it done.
If you disagree we are open to hear and move back to the former PR.
The main differences from the former PR are mostly around styling and making the migration pixel perfect as the current website.
Here are some differences we noticed on the former PR and made sure on this one:
Those styling errors are obvious, just open those 3 links and move between each other:
Also, we fixed all the remaining issues from PR #913 (some just solved themselves with the new code) and backported all the fixes and PRs that were added on top of it.
We’ve also upgraded all dependencies to latest (including all the old graphql related dependencies).
(except codemirror-graphql - we’ve found an issue there and submitted a PR, @acao let me know if you have time to go through it together quickly. anyway it’s not a blocker as the former version works)
Here is a link to an up to date deployment of the branch: https://guild-gatsby-graphql-org.netlify.app
We believe this PR is in a state that is better then the current deployed version and ready to be merged.
@saihaj @leebyron @IvanGoncharov @carolstran @mikeesto please review it and if there is nothing that is worse then the current website, let’s merge and deploy the new version asap and open again the options for people to contribute!
Last thing, in order to deploy this branch we need the credentials for Netfliy (to add GitHub token for our new sorting algorithm), Algolia (to have better indexing using gatsby plugin) and Google Analytics - @leebyron @brianwarner @caniszczyk could you help us with that?